deploy: combine provisioner and attacher, rename container names #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfontes
reviewed
Sep 4, 2018
| kind: ClusterRoleBinding | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| metadata: | ||
| name: driver-registrar-binding |
There was a problem hiding this comment.
from this whole renaming, the only 2 resources without do in their names are:
driver-registrar-bindingdriver-registrar-role
are these ❄️ special ? otherwise might as well change them too
There was a problem hiding this comment.
They don't, changing them 👍
|
|
and amazing work 👏This PR does the following: * combine the `csi-provisioner` and `csi-attacher` into a single `csi-do-controller` statefulset * rename the container name inside the `attacher` and `provisioner` statefulsets from `digitalocean-csi-plugin` to `csi-do-plugin` * rename the container name inside the `node` daemonset from `csi-doplugin` to `csi-do-plugin` * remove the RBAC's for the external attacher and provisioner as they are now included starting with K8S v1.10.5 * renamed the service account names to be consistent with the overall naming * removed the `Service` resources as those are not needed * changed the RBAC permission for the `node` plugin. It was too permissive (initially intended for the controller sidecars). * added a common label called `role=csi-do` to all pods, and `app=csi-do-controller` and `app=csi-do-node` to the controller and node plugin This allows you to get the pods or logs easily. Some example commands: ``` $ kubectl get pods -n kube-system NAME READY STATUS RESTARTS AGE csi-do-controller-0 3/3 Running 0 15s csi-do-node-4tkvh 2/2 Running 0 14s csi-do-node-4vjpr 2/2 Running 0 14s csi-do-node-thvjc 2/2 Running 0 14s kube-dns-64f766c69c-qsdnz 3/3 Running 0 49m kube-proxy-worker-7871 1/1 Running 1 48m kube-proxy-worker-7872 1/1 Running 1 49m kube-proxy-worker-7873 1/1 Running 1 48m kubernetes-dashboard-7dd4fc69c8-fs8s5 1/1 Running 0 49m $ kubectl get pods -l app=csi-do-controller -n kube-system NAME READY STATUS RESTARTS AGE csi-do-controller-0 3/3 Running 0 34s $ kubectl get pods -l app=csi-do-node -n kube-system NAME READY STATUS RESTARTS AGE csi-do-node-4tkvh 2/2 Running 0 39s csi-do-node-4vjpr 2/2 Running 0 39s csi-do-node-thvjc 2/2 Running 0 39s $ kubectl get pods -l role=csi-do -n kube-system NAME READY STATUS RESTARTS AGE csi-do-controller-0 3/3 Running 0 49s csi-do-node-4tkvh 2/2 Running 0 48s csi-do-node-4vjpr 2/2 Running 0 48s csi-do-node-thvjc 2/2 Running 0 48s ``` closes #53
fatih
force-pushed
the
combine-external-sidecars
branch
from
a59c3b4 to
7737cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
csi-provisionerandcsi-attacherinto a singlecsi-do-controllerstatefulsetattacherandprovisionerstatefulsets fromdigitalocean-csi-plugintocsi-do-pluginnodedaemonset fromcsi-doplugintocsi-do-pluginare now included starting with K8S v1.10.5
naming
Serviceresources as those are not needednodeplugin. It was toopermissive (initially intended for the controller sidecars).
role=csi-doto all pods, andapp=csi-do-controllerandapp=csi-do-nodeto the controller and nodeplugin
This allows you to get the pods or logs easily. Some example commands:
closes #53