Skip to content

driver: remove desc check #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2018
Merged

driver: remove desc check #59

merged 2 commits into from
Aug 20, 2018

Conversation

fatih
Copy link
Contributor

@fatih fatih commented Aug 20, 2018

The description might change, which would avoid making the check
invalid. Avoid doing it.

@fatih
Copy link
Contributor Author

fatih commented Aug 20, 2018

cc @lxfontes

@lxfontes
Copy link

lgtm on 🍏
it's not that it might change, it might have been created by a different system ( ex: control panel or manually via API )

@fatih
driver: remove desc check
8ced93f 
The description might change, which would avoid making the check
invalid. Avoid doing it.
@fatih fatih force-pushed the remove-desc-check branch from b97c6cd to 8ced93f Compare August 20, 2018 13:42
@fatih fatih merged commit 07f32d9 into master Aug 20, 2018
@fatih fatih deleted the remove-desc-check branch August 20, 2018 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fatih @lxfontes