Improve debug HTTP server usage #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is needed to unblock other pending PRs. |
- Rename the -address parameter to -debug-addr. - Only start the HTTP server on the Controller service: the Node service does not have a token configured and thus would never be able to respond successfully to a request. - Only start the debug server if -debug-addr is given, ensuring that existing users won't be surprised by the new functionality. This also allows us to test a dev version of the CSI plugin on a cluster where the port might already be used. - Remove explicit HTTP listener which is encapsulated by HTTP server. - Bound graceful HTTP server shutdown by 10 seconds.
timoreimann
force-pushed
the
improve-debug-http-server-usage
branch
from
b6f43e1 to
1f8e119
Compare
nicktate
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-addressparameter to-debug-addr.-debug-addris given, ensuring that existing users won't be surprised by the new functionality. This also allows us to test a dev version of the CSI plugin on a cluster where the port might already be used.