Update sidecars #236
Merged
Update sidecars #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
update-sidecars
branch
2 times, most recently
from
1fb57ae to
68f266d
Compare
- Update csi-provisioner from v1.1.0 to v1.4.0. - Update csi-attacher from v1.1.1 to v2.0.0. - provisioner: return content source field in CreatVolumeResponse to accommodate to behavioral change (see release nodes [1]). - attacher: add RBAC rules for PATCH operations (see release nodes [2]). - attacher: return OK response when droplet is found missing during ControllerUnpublishVolume operation to accommodate to behavior change (see release nodes [2]). Note that we did not update external-snapshotter to v1.2.0 since it requires a disruptive update to the alpha CRDs. Suggestion is to move to v2.0.0 straight on Kubernetes 1.17 where snapshotting graduated to beta. [1]: https://github.com/kubernetes-csi/external-provisioner/blob/v1.4.0/CHANGELOG-1.4.md [2]: https://github.com/kubernetes-csi/external-attacher/blob/v2.0.0/CHANGELOG-2.0.md
timoreimann
force-pushed
the
update-sidecars
branch
from
68f266d to
63f6815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we did not update external-snapshotter to v1.2.0 since it requires a disruptive update to the alpha CRDs. Suggestion is to move to v2.0.0 straight on Kubernetes 1.17 where snapshotting graduated to beta.
All changes were extensively tested using the upstream e2e tests. (Integration into our CSI repo coming, promised.)