driver: don't check limits on worker nodes #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're checking the volume limit during the driver startup. However because the driver is used both for the controller and node part, it fails during the node startup because we're deploying the driver to the nodes without a token. The DO token is only needed by the controller. The `checkLimit()` function would therefore print when deployed to the nodes: ``` time="2019-01-14T20:13:52Z" level=warning msg="CSI plugin will not function correctly, please resolve volume limit" error="rpc error: code = Internal desc = couldn't get account information to check volume limit: GET https://api.digitalocean.com/v2/account: 401 Unable to authenticate you." ``` This PR fixes that to not to call `checkLimit` if the token is not passed, which is a valid case for drivers deployed to the worker nodes. supersedes #127
timoreimann
approved these changes
Apr 19, 2019
driver/driver.go
Outdated
| @@ -58,6 +58,7 @@ type Driver struct { | |||
| nodeId string | |||
| region string | |||
| doTag string | |||
| hasToken bool | |||
There was a problem hiding this comment.
How about calling this isController? I think that would make the code a bit easier to understand and reduce the degree of comments we need below.
There was a problem hiding this comment.
Make sense, pushed some updates. I'll squash afterwards 👍
jcodybaker
pushed a commit
that referenced
this pull request
Apr 25, 2019
driver: don't check limits on worker nodes
jcodybaker
pushed a commit
that referenced
this pull request
Apr 26, 2019
driver: don't check limits on worker nodes
jcodybaker
added a commit
that referenced
this pull request
Apr 26, 2019
* Cherry-pick: Add tagging support for Volumes via the new `--do-tag` flag [[GH-130]](#130) * Cherry-pick: Fix support for volume snapshots by setting snapshot id on volume creation [[GH-129]](#129) * Cherry-pick: Goreportcard fixes (typos, exported variables, etc..) [[GH-121]](#121) * Cherry-pick: Rename the cluster role bindings for the `node-driver-registrar` to be consistent with the other role bindings. [[GH-118]](#118) * Cherry-pick: Remove the `--token` flag for the `csi-do-node` driver. Drivers running on the node don't need the token anymore. [[GH-118]](#118) * Cherry-pick: Don't check the volume limits on the worker nodes (worker nodes are not able to talk to DigitalOcean API) [[GH-142]](#142) * Cherry-pick: Update `godo` (DigitalOcean API package) version to v1.13.0 [[GH-143]](#143) * Cherry-pick: Fix race in snapshot integration test. [[GH-146]](#146) * Cherry-pick: Add tagging support for Volume snapshots via the new `--do-tag` flag [[GH-145]](#145)
jcodybaker
added a commit
that referenced
this pull request
Apr 26, 2019
* Cherry-pick: Add tagging support for Volumes via the new `--do-tag` flag [[GH-130]](#130) * Cherry-pick: Fix support for volume snapshots by setting snapshot id on volume creation [[GH-129]](#129) * Cherry-pick: Goreportcard fixes (typos, exported variables, etc..) [[GH-121]](#121) * Cherry-pick: Rename the cluster role bindings for the `node-driver-registrar` to be consistent with the other role bindings. [[GH-118]](#118) * Cherry-pick: Remove the `--token` flag for the `csi-do-node` driver. Drivers running on the node don't need the token anymore. [[GH-118]](#118) * Cherry-pick: Don't check the volume limits on the worker nodes (worker nodes are not able to talk to DigitalOcean API) [[GH-142]](#142) * Cherry-pick: Update `godo` (DigitalOcean API package) version to v1.13.0 [[GH-143]](#143) * Cherry-pick: Fix race in snapshot integration test. [[GH-146]](#146) * Cherry-pick: Add tagging support for Volume snapshots via the new `--do-tag` flag [[GH-145]](#145)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're checking the volume limit during the driver startup. However
because the driver is used both for the controller and node part, it
fails during the node startup because we're deploying the driver to the
nodes without a token. The DO token is only needed by the controller.
The
checkLimit()function would therefore print when deployed to thenodes:
This PR fixes that to not to call
checkLimitif the token is notpassed, which is a valid case for drivers deployed to the worker nodes.
supersedes #127