Tag volumes on Create/Attach #130
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,153 @@ | ||
| package driver | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "net/http" | ||
| "testing" | ||
|
|
||
| "github.com/digitalocean/godo" | ||
| ) | ||
|
|
||
| func TestTagger(t *testing.T) { | ||
| tag := "k8s:my-cluster-id" | ||
| tcs := []struct { | ||
| name string | ||
| vol *godo.Volume | ||
| createTagFunc func(ctx context.Context, req *godo.TagCreateRequest) (*godo.Tag, *godo.Response, error) | ||
| tagResourcesFunc func(context.Context, string, *godo.TagResourcesRequest) (*godo.Response, error) | ||
| tagExists bool | ||
| expectCreates int | ||
| expectTagResources int | ||
| expectError bool | ||
| expectTags int | ||
| }{ | ||
| { | ||
| name: "success existing tag", | ||
| vol: &godo.Volume{ID: "hello-world"}, | ||
| expectTagResources: 1, | ||
| tagExists: true, | ||
| expectTags: 1, | ||
| }, | ||
| { | ||
| name: "success with new tag", | ||
| vol: &godo.Volume{ID: "hello-world"}, | ||
| expectCreates: 1, | ||
| expectTagResources: 2, | ||
| expectTags: 1, | ||
| }, | ||
| { | ||
| name: "success already tagged", | ||
| vol: &godo.Volume{ | ||
| ID: "hello-world", | ||
| Tags: []string{tag}, | ||
| }, | ||
| expectCreates: 0, | ||
| expectTagResources: 0, | ||
| }, | ||
| { | ||
| name: "failed first tag", | ||
| vol: &godo.Volume{ID: "hello-world"}, | ||
| expectCreates: 0, | ||
| expectTagResources: 1, | ||
| expectError: true, | ||
| tagResourcesFunc: func(context.Context, string, *godo.TagResourcesRequest) (*godo.Response, error) { | ||
| return nil, errors.New("an error") | ||
| }, | ||
| }, | ||
| { | ||
| name: "failed create tag", | ||
| vol: &godo.Volume{ID: "hello-world"}, | ||
| expectCreates: 1, | ||
| expectTagResources: 1, | ||
| expectError: true, | ||
| createTagFunc: func(ctx context.Context, req *godo.TagCreateRequest) (*godo.Tag, *godo.Response, error) { | ||
| return nil, nil, errors.New("an error") | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range tcs { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
|
|
||
| tagService := &fakeTagsDriver{ | ||
| createFunc: tc.createTagFunc, | ||
| tagResourcesFunc: tc.tagResourcesFunc, | ||
| exists: tc.tagExists, | ||
| } | ||
| driver := &Driver{ | ||
| doTag: tag, | ||
| tags: tagService, | ||
| } | ||
|
|
||
| err := driver.tagVolume(context.Background(), tc.vol) | ||
|
|
||
| if err != nil && !tc.expectError { | ||
| t.Errorf("expected success but got error %v", err) | ||
| } else if tc.expectError && err == nil { | ||
| t.Error("expected error but got success") | ||
| } | ||
|
|
||
| if tagService.createCount != tc.expectCreates { | ||
| t.Errorf("createCount was %d, expected %d", tagService.createCount, tc.expectCreates) | ||
| } | ||
| if tagService.tagResourcesCount != tc.expectTagResources { | ||
| t.Errorf("tagResourcesCount was %d, expected %d", tagService.tagResourcesCount, tc.expectTagResources) | ||
| } | ||
| if tc.expectTags != len(tagService.resources) { | ||
| t.Errorf("expected %d tagged volume, %d found", tc.expectTags, len(tagService.resources)) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| type fakeTagsDriver struct { | ||
| createFunc func(ctx context.Context, req *godo.TagCreateRequest) (*godo.Tag, *godo.Response, error) | ||
| tagResourcesFunc func(context.Context, string, *godo.TagResourcesRequest) (*godo.Response, error) | ||
| exists bool | ||
| resources []godo.Resource | ||
| createCount int | ||
| tagResourcesCount int | ||
| } | ||
|
|
||
| func (*fakeTagsDriver) List(context.Context, *godo.ListOptions) ([]godo.Tag, *godo.Response, error) { | ||
| panic("not implemented") | ||
| } | ||
|
|
||
| func (*fakeTagsDriver) Get(context.Context, string) (*godo.Tag, *godo.Response, error) { | ||
| panic("not implemented") | ||
| } | ||
|
|
||
| func (f *fakeTagsDriver) Create(ctx context.Context, req *godo.TagCreateRequest) (*godo.Tag, *godo.Response, error) { | ||
| f.createCount++ | ||
| if f.createFunc != nil { | ||
| return f.createFunc(ctx, req) | ||
| } | ||
| f.exists = true | ||
| return &godo.Tag{ | ||
| Name: req.Name, | ||
| }, godoResponse(), nil | ||
| } | ||
|
|
||
| func (*fakeTagsDriver) Delete(context.Context, string) (*godo.Response, error) { | ||
| panic("not implemented") | ||
| } | ||
|
|
||
| func (f *fakeTagsDriver) TagResources(ctx context.Context, tag string, req *godo.TagResourcesRequest) (*godo.Response, error) { | ||
| f.tagResourcesCount++ | ||
| if f.tagResourcesFunc != nil { | ||
| return f.tagResourcesFunc(ctx, tag, req) | ||
| } | ||
| if !f.exists { | ||
| return &godo.Response{ | ||
| Response: &http.Response{StatusCode: 404}, | ||
| Rate: godo.Rate{Limit: 10, Remaining: 10}, | ||
| }, errors.New("An error occured") | ||
| } | ||
| f.resources = append(f.resources, req.Resources...) | ||
| return godoResponse(), nil | ||
| } | ||
|
|
||
| func (*fakeTagsDriver) UntagResources(context.Context, string, *godo.UntagResourcesRequest) (*godo.Response, error) { | ||
| panic("not implemented") | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that came to my mind yesterday is that we shouldn't tag the volume if no values have been passed to
--do-tag. This driver is also used by people who don't use our managed service, so in their case--do-tagwill be most probably empty. We should change it therefore to: