csi: implement Snapshot functionality #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aybabtme
reviewed
Nov 14, 2018
driver/controller.go
Outdated
| // snapshot already exists, return the information we have | ||
| createdAt, err := time.Parse(time.RFC3339, snap.Created) | ||
| if err != nil { | ||
| return nil, status.Errorf(codes.Internal, "couldn't parse snapshot's created field: %s", err.Error()) |
There was a problem hiding this comment.
use a fmt.Errorf here, not a grpc error
aybabtme
reviewed
Nov 14, 2018
driver/controller.go
Outdated
| snapshots = snapshots[:req.MaxEntries] | ||
| } | ||
|
|
||
| var entries []*csi.ListSnapshotsResponse_Entry |
There was a problem hiding this comment.
entries := make([]*csi.ListSnapshotsResponse_Entry, 0, len(snapshots))
aybabtme
reviewed
Nov 14, 2018
driver/controller.go
Outdated
| ll.Info("list snapshots is called") | ||
|
|
||
| // fetch all entries | ||
| listOpts := &godo.ListOptions{} |
There was a problem hiding this comment.
maybe set the listOpts.PerPage = req.MaxEntries value here. not guaranteed to be respected but at least it'll avoid making unnecessary calls if the two align
aybabtme
reviewed
Nov 14, 2018
| return nil, err | ||
| } | ||
|
|
||
| listOpts.Page = page + 1 |
There was a problem hiding this comment.
also set listOpts.PerPage according to the response you got
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Snapshot functionality. We're passing all unit test successfully.