Replace monkey patching #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@segphault thanks for submitting the PR! This certainly makes the code better. The specs don't pass, for either Ruby or RubyMotion. So I'm going to go ahead and merge the changes and then push the fixes on top it. |
|
@segphault thanks again for the PR. I've released a new gem version, and I'll have the plugins updated shortly. |
|
Thanks for accepting it so quickly! I really appreciate your efforts on this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes extensions that are made to the core Integer and String classes:
to_utf8_character,charCodeAt, andslice_to_end.Monkey-patching the core library can cause problems, such as unintentionally coupling code to the library or causing conflicts with other libraries that have their own conflicting core extensions.
I realize that this change may prove problematic for any third-party plugins that are relying on these added functions. If it would help, I'm happy to submit the necessary corresponding changes in the motion-markdown-it-plugins repository.