redirect see other for auth #2199
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
This PR adds
redirectTo*SeeOtherhelpers (HTTP 303) and uses them in the auth Sessions controller.With 302 after a non-GET (ex:
DELETElogout), some clients (notably in HTMX flows) can follow the redirect using the same method, meaning the redirect target gets hit with DELETE instead of GET. With 303 See Other, the client must follow the redirect with a GET, which fixes logout/login redirects.HTMX impact
Before, using
hx-deletefor logout could cause the redirect step to also be a DELETE, so you needed a form +_method=DELETEworkaround.Now this works cleanly: