Fix grepping for direnv, add profile files to messages #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because if one of the files ~/.bashrc, ~/.bash_profile didn't exist, but the other file contained the string "direnv", grep returned non-zero exit status.
mpscholten
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on Linux Mint (an Ubuntu derivative). I'm using the bash shell. The file
~/.bash_profiledoesn't exist on my machine. My~/.bashrcfile contains theeval "$(direnv hook bash)"line.The script displayed a
greperror saying that the~/.bash_profilefile does not exist and instructed me to add the line above to~/.bashrc, which I already did.It looks like the fix works in my config. I didn't try it on
zsh. Unfortunately I'm not sure if this is a POSIX-compliant solution.