Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 'BadZipFile' #161

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

evandemaris
Copy link

This fixes the issue with a hardcoded closure compiler filename, which prevents initialization as the filename has changed with updated versions.

fix digitalfruit#160
A pull request to fix was submitted, but the code broke when the compiler version updated last month. This should fix it and prevent it from breaking again (at least in the near future).
Fix closure compiler & closure templates
iterator variable `info` was renamed to `name`.
@alexcat3
Copy link

alexcat3 commented Jul 5, 2017

Please merge this pull request! This fixes a problem that is currently making LimeJS uninstallable for me:
The current code in master/limejs/lime.py appears to download the Closure Compiler from the Google Code domain closure-compiler.googlecode.com. Google Code has been discontinued, and now all requests to that domain return an error 404. This pull request changes the code to use the current URL.

@evandemaris
Copy link
Author

evandemaris commented Jul 8, 2017

@alexcat3 I believe the authors have abandoned this (no updates since 2015) - to my knowledge, my fork is the only way to use limejs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants