Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2948: Start a new chat for each region #2957

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

steffenkleinle
Copy link
Member

@steffenkleinle steffenkleinle commented Oct 14, 2024

Short description

Start a new chat for each region instead of sharing the chat instance.
This would break the chat in the backend.

Proposed changes

Store the id of the chat in the local storage related to the city.

Side effects

⚠️ Previous chats won't work anymore (unless the chat id is copied manually to the new local storage entry).

Testing

Open the chat in testumgebung and send a message.
Then go to muenchen and open the chat and confirm that there is no chat yet.

Resolved issues

Fixes: #2948, digitalfabrik/integreat-chat#54.


@steffenkleinle
Copy link
Member Author

steffenkleinle commented Oct 14, 2024

⚠️ @svenseeberg Previous chats won't work anymore after this PR is released to production (unless the chat id is copied manually to the new local storage entry).
Do you think we have to notify any of our testers of that?

Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested in Firefox

Copy link
Member

@ztefanie ztefanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on firefox and chrome 👍

Copy link

codeclimate bot commented Oct 17, 2024

Code Climate has analyzed commit 9535b0a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.2%.

View more on Code Climate.

@steffenkleinle steffenkleinle merged commit 404822d into main Oct 17, 2024
8 of 9 checks passed
@steffenkleinle steffenkleinle deleted the 2948-unique-chat-id branch October 17, 2024 07:34
@svenseeberg
Copy link
Member

Previous chats won't work anymore after this PR is released to production

This is totally fine. We are currently in an alpha stage and breaking changes are totally acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chat] Chat ID should be unique per region
4 participants