1233: Implement lists as actual list #2521
Conversation
lunars97
requested review from
steffenkleinle,
sarahsporck,
ztefanie,
f1sh1918 and
LeandraH
as code owners
…33-implement-lists-as-actual-lists
…italfabrik/integreat-app into 1233-implement-lists-as-actual-lists
…33-implement-lists-as-actual-lists
…italfabrik/integreat-app into 1233-implement-lists-as-actual-lists
There was a problem hiding this comment.
This issue is for both web and native and I think there is quite a few places where we don't use lists. Probably we shouldn't use lists in all these cases, but just examples (all found by searching for .map() functions in the code):
- native: Categories.jsx -> Footer
- native: CalendarChoiceModal
- native: CategoryListItem -> rendering of sub category list items
- native: Selector
- native: OpeningHours
- native: PoiFilters
- web: CitySelector
- web: OpeningHours
- web: PoiFilters
- web: SearchPage
- web: Selector
So probably we should split up the issue and do some more research in which cases it makes sense and in which cases it does not make sense.
|
Let's have a chat about this in Monday's Weekly? |
…33-implement-lists-as-actual-lists
lunars97
force-pushed
the
1233-implement-lists-as-actual-lists
branch
from
eb015c2
to
75a9e2d
Compare
…33-implement-lists-as-actual-lists
lunars97
force-pushed
the
1233-implement-lists-as-actual-lists
branch
from
75a9e2d
to
25a7757
Compare
…33-implement-lists-as-actual-lists
lunars97
force-pushed
the
1233-implement-lists-as-actual-lists
branch
from
50e84c7
to
7e45d3d
Compare
…33-implement-lists-as-actual-lists
…33-implement-lists-as-actual-lists
…italfabrik/integreat-app into 1233-implement-lists-as-actual-lists
…33-implement-lists-as-actual-lists
…italfabrik/integreat-app into 1233-implement-lists-as-actual-lists
…33-implement-lists-as-actual-lists
…italfabrik/integreat-app into 1233-implement-lists-as-actual-lists
There was a problem hiding this comment.
Looks good 🎉 Nice work.
Tested on Android, works fine.
If you fix something we mentioned in a comment, you can click "resolve conversation", so it is easy to see, which conversations are open and need e.g. an answer and which one are "done".
Also please squash the commits into one commit.
It is really nice to see, how you never give up and always make your PRs nice and functioning code. Well done 👏
…33-implement-lists-as-actual-lists
…italfabrik/integreat-app into 1233-implement-lists-as-actual-lists
…33-implement-lists-as-actual-lists
Short description
Implement lists as actual list for accessibility according to Prüfbericht
zur Barrierefreiheit
Proposed changes
Resolved issues
Fixes: #2167