Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2516: Merge stylelint configs and lint styled-components #2517

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

sarahsporck
Copy link
Contributor

Short description

The bigger change is linting styled components. Stylelint also supports --fix, for most of its rules, so this PR was not much work. If you would like to have some more rules disabled/off, write a comment :)

Proposed changes

  • merge stylelint configs
  • lint styled components (I mostly reused the default rules here)

Side effects

  • hopefully nothing :)

Resolved issues

Fixes: #2516


@sarahsporck sarahsporck linked an issue Oct 11, 2023 that may be closed by this pull request
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@sarahsporck sarahsporck merged commit 7d51d84 into main Oct 13, 2023
8 checks passed
@sarahsporck sarahsporck deleted the 2516-merge-stylelint-configs branch October 13, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge stylelint configs
3 participants