Skip to content

Dispatch change event after validator error #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tommyneu wants to merge 2 commits into
base: 4.0
Choose a base branch
from
Open

Dispatch change event after validator error #578

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df26f09
Dispatch change event after validator error
tommyneu Jan 6, 2026
081c3bf
Added validation failed class input
tommyneu Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions js/components/dcf-file-size-validator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ export default class DCFFileSizeValidator {

sizeLimit = -1;

validationFailedClass = null;

constructor(fileInput, options) {

if ('errorElementClassList' in options && Array.isArray(options.errorElementClassList)) {
Expand All @@ -25,6 +27,7 @@ export default class DCFFileSizeValidator {

// Get the max size limit
this.sizeLimit = this.#parseSize(this.fileInputElement.dataset.maxSize);
this.validationFailedClass = this.fileInputElement.dataset.validationFailedClass;

this.formattedSizeOutputs.forEach((singleOutputElement) => {
singleOutputElement.innerHTML = this.#formatSize(this.sizeLimit);
Expand All @@ -39,6 +42,9 @@ export default class DCFFileSizeValidator {
// Run logic when the file input's file changes
this.fileInputElement.addEventListener('change', () => {
this.errorElement.classList.add('dcf-d-none!');
if (this.validationFailedClass !== null) {
this.fileInputElement.classList.remove(this.validationFailedClass);
}

// There is no file so we are good
if (this.fileInputElement.files.length === 0) {
Expand All @@ -47,9 +53,16 @@ export default class DCFFileSizeValidator {

// File is too big do not keep it and show error
if (this.fileInputElement.files[0].size > this.sizeLimit) {
this.errorElement.innerText = `The file '${this.fileInputElement.files[0].name}' is too large!`;
this.errorElement.classList.remove('dcf-d-none!');
const filename = this.fileInputElement.files[0].name;

this.fileInputElement.value = '';
if (this.validationFailedClass !== null) {
this.fileInputElement.classList.add(this.validationFailedClass);
}
this.fileInputElement.dispatchEvent(new CustomEvent('change'));

this.errorElement.innerText = `The file '${filename}' is too large!`;
this.errorElement.classList.remove('dcf-d-none!');
return;
}
});
Expand Down