Try out ruff
#227
Open
Try out ruff
#227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
anatoly-scherbakov
requested review from
BigBlueHat,
davidlehn and
mielvds
and removed request for
mielvds
mielvds
approved these changes
Dec 21, 2025
Collaborator
mielvds
left a comment
mielvds
left a comment
There was a problem hiding this comment.
Big supporter of this; I use ruff myself. Flake8 is also fine, as long as there is some formatter. Ruff includes flake8 & beyond, so obvious choice
Collaborator
|
@anatoly-scherbakov maybe one question: is the config aligned with the one from rdflib? |
Collaborator
Author
|
@mielvds not sure, can look into a comparison 👀 It won't be a 100% match since |
Collaborator
Author
|
@mielvds I have checked this out and found two particular differences, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We do not have a code formatter that would help us unify the codebase.
What
Implement
ruff. Run it in CI, but only against one file: to taste it and to reduce the probability of git conflicts.