Conversation
- `ky@1.14.2`. - `undici@6.23.0`.
- `eslint@9`. - `eslint-config-digitalbazaar` to `@digitalbazaar/eslint-config@7`. - Fix lint issues.
- Update dev dependencies. - Update test dependencies.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 94.09% 94.06% -0.03%
==========================================
Files 4 4
Lines 237 236 -1
==========================================
- Hits 223 222 -1
Misses 14 14
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| timeout-minutes: 10 | ||
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 22.x, 24.x] |
There was a problem hiding this comment.
18 is EOL so we don't need to test against it.
| node-version: [18.x, 20.x, 22.x, 24.x] | |
| node-version: [20.x, 22.x, 24.x] |
There was a problem hiding this comment.
Understood. I was leaving it at 18.x since the only support issue is the trivial testing need to use chai@4 vs 5+. I thought it would be good to be a bit more conservative in this case since this library might have wider use than many of our others in part due to the use in jsonld.js, which still supports 18.x. An undici@7 update would force the issue, so I thought it would be fine to wait until that change is tested to drop old version testing.
4 participants
Further research and testing needed to see if an update to undici@7 is a breaking change or not.