Add shutdown. #111
Open
Add shutdown. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlehn
force-pushed
the
add-shutdown
branch
2 times, most recently
from
753a325
to
35a62fd
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 81.45% 81.37% -0.09%
==========================================
Files 10 10
Lines 1941 1954 +13
==========================================
+ Hits 1581 1590 +9
- Misses 360 364 +4
Continue to review full report in Codecov by Sentry.
|
dlongley
approved these changes
Mar 9, 2024
The `shutdown()` call performs an orderly shutdown and emits events. This differs from the current `exit()` and `process.exit()` behavior which is more immediate.
|
This does not appear to impact how Bedrock behaves when it receives a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
shutdown()API is added to perform orderly shutdown. This came about due to howbedrock-testwas exiting. In the flow it uses, callingbedrock.exit()orprocess.exit()after successful testing results in a more abrupt shutdown. There isn't a way to exit and emit orderly events on the way. In some testing cases you may wantbedrock.exitor similar events to trigger to do cleanup.This patch attempts to keep the same semantics for current code and only adds the
shutdown()call (and does some refactoring). Retaining all prior behavior in all cases isn't well tested. Help wanted.shutdown()could be named something else or be hacked intoexit()as options, but this seemed like a simple approach. At the time this was written, it wasn't namedstop(), but now I can't recall the reasoning and that might be a better choice as it aligns with start/stop semantics and event naming. Comments welcome.