Backport Daml Driver for PostgreSQL additional startup options to main #8904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable migration only option for startup CHANGELOG_BEGIN [Daml Driver for PostgreSQL] Enable migrate only option at startup CHANGELOG_END * scalafmt * Rationalize names of the sql start modes * no op ledger * scalafmt * WIP: choose to run migrationOnly in Main * revert changes to startup options for sandboxnext * add sql-start-mode parameter to CLI, validate it * scalafmt * Update documentation * delete some WIP experiments * removed unused import * Reorder migrate to properly initialize dao * use lowercase delimitted options rather than initial caps for sql-start-mode options * remove redundant parens * exit after running migration scripts * return future for flyway migration, only exit on complete, use cached threadpool execution context * scalafmt * correct options in docs to lowercase dash delimited
dasormeter
requested review from
gerolf-da and
rautenrieth-da
as code owners
dasormeter
changed the title
cocreature
approved these changes
Feb 19, 2021
|
Think you can get a test case in for this? It'd be easy to break in the future. |
|
Yup will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable sql-start-mode option for daml-on-sql (backported from 1.10.1 release)
CHANGELOG_BEGIN
[Daml Driver for PostgreSQL] Enable migrate only option at startup
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.