Skip to content

Extend preprocess input size costs to the transaction tree #21955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extend preprocess input size costs to the transaction tree #21955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 107 additions & 1 deletion sdk/daml-lf/transaction/src/main/scala/com/digitalasset/daml/lf/data/CostModel.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@ package com.digitalasset.daml.lf
package data

import com.digitalasset.daml.lf.command.ApiContractKey
import com.digitalasset.daml.lf.{transaction => tx}
import com.digitalasset.daml.lf.transaction.{
CreationTime,
FatContractInstance,
FatContractInstanceImpl,
GlobalKey,
GlobalKeyWithMaintainers,
Node,
}
import com.digitalasset.daml.lf.value.Value
import com.digitalasset.daml.lf.{command, crypto, language}
Expand Down Expand Up @@ -47,6 +49,8 @@ private[lf] object CostModel {

implicit def costOfUnit(value: Unit): Cost

implicit def costOfBoolean(value: Boolean): Cost

implicit def costOfValue(value: Value): Cost

implicit def costOfFatContractInstance(value: FatContractInstance): Cost
Expand Down Expand Up @@ -86,6 +90,10 @@ private[lf] object CostModel {
implicit def costOfSet[A](value: Set[A])(implicit elemCost: A => Cost): Cost

implicit def costOfTreeSet[A](value: TreeSet[A])(implicit elemCost: A => Cost): Cost

implicit def costOfNodeId(value: tx.NodeId): Cost

implicit def costOfTxNode(value: tx.Node): Cost
}

object EmptyCostModelImplicits extends CostModelImplicits {
Expand Down Expand Up @@ -113,6 +121,8 @@ private[lf] object CostModel {

implicit def costOfUnit(value: Unit): Cost = 0L

implicit def costOfBoolean(value: Boolean): Cost = 0L

implicit def costOfValue(value: Value): Cost = 0L

implicit def costOfFatContractInstance(value: FatContractInstance): Cost = 0L
Expand Down Expand Up @@ -153,6 +163,10 @@ private[lf] object CostModel {
implicit def costOfSet[A](value: Set[A])(implicit elemCost: A => Cost): Cost = 0L

implicit def costOfTreeSet[A](value: TreeSet[A])(implicit elemCost: A => Cost): Cost = 0L

implicit def costOfNodeId(value: tx.NodeId): Cost = 0L

implicit def costOfTxNode(value: tx.Node): Cost = 0L
}

object StructuralCostModelImplicits extends CostModelImplicits {
Expand Down Expand Up @@ -181,7 +195,9 @@ private[lf] object CostModel {

implicit def costOfLong(value: Long): Cost = 8

implicit def costOfUnit(value: Unit): Cost = 0
implicit def costOfUnit(value: Unit): Cost = 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No cost value for a unit value doesn't feel correct - hence bumped to a measure of 1


implicit def costOfBoolean(value: Boolean): Cost = 1

implicit def costOfValue(value: Value): Cost = value match {
case Value.ValueBool(_) =>
Expand Down Expand Up @@ -325,5 +341,95 @@ private[lf] object CostModel {

implicit def costOfTreeSet[A](value: TreeSet[A])(implicit elemCost: A => Cost): Cost =
1 + value.map(elemCost).sum.toLong

implicit def costOfNodeId(value: tx.NodeId): Cost =
1 + costOfInt(value.index)

implicit def costOfTxNode(value: tx.Node): Cost = value match {
case Node.Create(
coid,
packageName,
templateId,
arg,
signatories,
stakeholders,
keyOpt,
version,
) =>
1 + costOfContractId(coid) +
costOfString(packageName) +
costOfIdentifier(templateId) +
costOfValue(arg) +
costOfSet(signatories) +
costOfSet(stakeholders) +
costOfOption(keyOpt) +
costOfLanguageVersion(version)
case Node.Fetch(
coid,
packageName,
templateId,
actingParties,
signatories,
stakeholders,
keyOpt,
byKey,
interfaceId,
version,
) =>
1 + costOfContractId(coid) +
costOfString(packageName) +
costOfIdentifier(templateId) +
costOfSet(actingParties) +
costOfSet(signatories) +
costOfSet(stakeholders) +
costOfOption(keyOpt) +
costOfBoolean(byKey) +
costOfOption(interfaceId) +
costOfLanguageVersion(version)
case Node.LookupByKey(packageName, templateId, key, result, version) =>
1 + costOfString(packageName) +
costOfIdentifier(templateId) +
costOfGlobalKeyWithMaintainers(key) +
costOfOption(result) +
costOfLanguageVersion(version)
case Node.Exercise(
targetCoid,
packageName,
templateId,
interfaceId,
choiceId,
consuming,
actingParties,
chosenValue,
stakeholders,
signatories,
choiceObservers,
choiceAuthorizers,
children,
exerciseResult,
keyOpt,
byKey,
version,
) =>
1 + costOfContractId(targetCoid) +
costOfString(packageName) +
costOfIdentifier(templateId) +
costOfOption(interfaceId) +
costOfString(choiceId) +
costOfBoolean(consuming) +
costOfSet(actingParties) +
costOfValue(chosenValue) +
costOfSet(stakeholders) +
costOfSet(signatories) +
costOfSet(choiceObservers) +
costOfOption(choiceAuthorizers) +
costOfImmArray(children) +
costOfOption(exerciseResult) +
costOfOption(keyOpt) +
costOfBoolean(byKey) +
costOfLanguageVersion(version)
case Node.Rollback(children) =>
1 + costOfImmArray(children)
}
}
}