Skip to content

Implement Daml/Engine cost model infrastructure for pure builtins #21668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 15, 2025
Merged

Implement Daml/Engine cost model infrastructure for pure builtins #21668

merged 12 commits into from
Aug 15, 2025

Conversation

carlpulley-da
Copy link
Contributor

@carlpulley-da carlpulley-da commented Aug 11, 2025 •
edited
Loading

  • Wire up Speedy pure builtins to cost model
  • Wire up Speedy builtins to cost model overflow

@carlpulley-da carlpulley-da self-assigned this Aug 11, 2025
@carlpulley-da carlpulley-da linked an issue Aug 11, 2025 that may be closed by this pull request
Implement Daml/Engine cost model infrastructure #21635
Open
@carlpulley-da carlpulley-da changed the base branch from main to remy/cost-model August 11, 2025 19:28
@carlpulley-da carlpulley-da changed the base branch from remy/cost-model to main August 12, 2025 08:44
@carlpulley-da carlpulley-da changed the base branch from main to remy/cost-model August 13, 2025 16:25
remyhaemmerle-da
remyhaemmerle-da reviewed Aug 14, 2025
View reviewed changes
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty nice.
I will separate the "cost model", that just says what is the cost of all primitves, from the "budget" that tracks of the total cost.

@remyhaemmerle-da remyhaemmerle-da marked this pull request as ready for review August 15, 2025 07:21
@remyhaemmerle-da remyhaemmerle-da requested a review from a team as a code owner August 15, 2025 07:21
@remyhaemmerle-da remyhaemmerle-da merged commit 3cd3aba into remy/cost-model Aug 15, 2025
14 of 15 checks passed
@remyhaemmerle-da remyhaemmerle-da deleted the cjp/issue-21635-pure-builtins branch August 15, 2025 07:22
remyhaemmerle-da pushed a commit that referenced this pull request Aug 15, 2025
@carlpulley-da @remyhaemmerle-da
Implement Daml/Engine cost model infrastructure for pure builtins (#2…
a093aff 
…1668)

* Implement Daml/Engine cost model infrastructure for pure builtins

* Add in checks for pure builtins being within cost budgets

* Build fixes

* grpc parser fixes

* More ci fixes

* script service protobuf fixes

* compiler fixes

* doc sync

* Move Cost.Error into Dev scope

* build fix

* doc sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyhaemmerle-da remyhaemmerle-da remyhaemmerle-da approved these changes

Assignees

@carlpulley-da carlpulley-da

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Daml/Engine cost model infrastructure
2 participants
@carlpulley-da @remyhaemmerle-da