Add metadata checks to upgraded dar #19978
Open
+290
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-williams-da
force-pushed
the
sw/upgrade-dar-metadata-checks
branch
from
9e2253b
to
b6d715b
Compare
There was a problem hiding this comment.
Since my ghcide changed the default behaviour of define, we can either rely on our tests to ensure this doesn't affect anything, or I could run all tests with a version of ghcide that errors if the diag file doesn't match the rule file, to be certain.
Unsure if this is worthwhile
| packageVersionLt = (<) `on` fmap (read @Int) . splitWhen (=='.') . T.unpack . LF.unPackageVersion | ||
|
|
||
| -- We assume major will always be 1 (or at least the same), since Version.supportedOutputVersions does not contain any 2. versions | ||
| -- TODO: Is this acceptable? |
There was a problem hiding this comment.
Double check this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ghcide PR
I've also verified that the errors show on the daml.yaml file in VSCode, and that it plays nicely with Multi-ide's reporting to daml.yaml when the IDE can't start