[fwd port] check view consistency in fetch/exercise by interface #19957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbrauner-da
force-pushed
the
pb/check-views-in-exercise-by-interface-3.x
branch
2 times, most recently
from
7b28269
to
025e75d
Compare
paulbrauner-da
changed the base branch from
main
to
sw/new-fetch-interface-fix-3x
samuel-williams-da
force-pushed
the
sw/new-fetch-interface-fix-3x
branch
from
1784fe1
to
a808392
Compare
--------- Co-authored-by: Remy <remy.haemmerle@daml.com>
paulbrauner-da
force-pushed
the
pb/check-views-in-exercise-by-interface-3.x
branch
from
025e75d
to
94c395b
Compare
remyhaemmerle-da
approved these changes
Oct 1, 2024
Comment on lines
48
to
49
| val ifacePkgName = Ref.PackageName.assertFromString("-iface-pkg-") | ||
| val ifacePkgId = Ref.PackageId.assertFromString("-iface-package-id-") |
There was a problem hiding this comment.
extremely picky comment.
why -iface-pkg- and -iface-package-
Comment on lines
105
to
106
| // TODO: revert to the default compiler config once it supports upgrades | ||
| Compiler.Config.Dev(LanguageMajorVersion.V2), |
There was a problem hiding this comment.
can we factorize the version and the comment (lines 52, 82 and here) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #19857. Because
mainonly has soft fetches, its code is quite different frommain-2.x: there is no morefetchAnyfor instance. So the port is not a mere cherry-pick, I had to tweak it and it could benefit from a proper review.make sure to hide whitespace changes when reviewing