Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fwd port, compiler] forbid adding new interface instances to the upgraded version of a template #19934

Merged

Conversation

paulbrauner-da
Copy link
Contributor

Fwd port of #19820

@paulbrauner-da paulbrauner-da force-pushed the pb/forbid-new-iface-impls-in-upgrades-compiler-3.x branch from 22d47e1 to 18f6386 Compare September 16, 2024 09:15
…ion of a template (#19820)

* [compiler] forbid adding new interface instances to the upgraded version of a template

* allow adding new instances to new templates

* add two more tests
@paulbrauner-da paulbrauner-da force-pushed the pb/forbid-new-iface-impls-in-upgrades-compiler-3.x branch from 18f6386 to 2fdf6cf Compare September 16, 2024 09:24
@paulbrauner-da paulbrauner-da marked this pull request as ready for review September 16, 2024 12:17
@paulbrauner-da paulbrauner-da requested a review from a team as a code owner September 16, 2024 12:17
@paulbrauner-da paulbrauner-da merged commit 8189fb9 into main Sep 16, 2024
14 checks passed
@paulbrauner-da paulbrauner-da deleted the pb/forbid-new-iface-impls-in-upgrades-compiler-3.x branch September 16, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants