Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop strict preprocessing mode #19912

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Drop strict preprocessing mode #19912

merged 2 commits into from
Sep 23, 2024

Conversation

remyhaemmerle-da
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da commented Sep 11, 2024

preliminary work for #19914

@remyhaemmerle-da remyhaemmerle-da marked this pull request as ready for review September 11, 2024 13:03
@remyhaemmerle-da remyhaemmerle-da requested a review from a team September 11, 2024 13:03
Copy link
Contributor

@samuel-williams-da samuel-williams-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A brave change, I'm kind of surprised it didn't break any tests...
Should it have?

@remyhaemmerle-da
Copy link
Collaborator Author

The non-strict mode is usefull for non upgradable LF, so it is not useful in 3.x

@remyhaemmerle-da remyhaemmerle-da merged commit 4c9944f into main Sep 23, 2024
14 checks passed
@remyhaemmerle-da remyhaemmerle-da deleted the remy-preprocessing branch September 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants