Fix disclosure bug in the presence of upgrades #19167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbrauner-da
changed the title
samuel-williams-da
approved these changes
May 9, 2024
sdk/daml-script/runner/src/main/scala/com/daml/lf/engine/script/v1/ScriptF.scala
Outdated
Show resolved
Hide resolved
sdk/daml-script/runner/src/main/scala/com/daml/lf/engine/script/v1/ScriptF.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19162
Disclosures in exercise commands are accompanied by a template ID, and the ledger API verifies that the blob's template ID matches the provided one. The
GrpcLedgerClientclass was not always returning matching blobs and template IDs for disclosure queries. Submitting these retrieved disclosures+IDs as part of an exercise was then leading to runtime errors. This PR fixes that.In addition, the
Disclosuredaml opaque datatype stores a blob and the purported template ID of the contract encoded by the blob. We fix thequeryContractIdcommand of daml script so that it receives not only the requested (possibly upgraded) contract and its blob, but also the template ID of the blob, thus creating validDisclosures.Not blocking for this PR but worth noting: @remyhaemmerle-da pointed out that the current design of
Disclosureas an opaque type is not ideal: there is no way for a user to know what the concrete type of a disclosure they requested actually is (they could have requested a v2 and gotten a v1).