Make keys 2.dev-only #18573
Merged
Make keys 2.dev-only #18573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbrauner-da
force-pushed
the
pb/keys-dev-only
branch
from
fdb4b16
to
113690f
Compare
paulbrauner-da
changed the title
paulbrauner-da
force-pushed
the
pb/keys-dev-only
branch
from
113690f
to
f202618
Compare
paulbrauner-da
force-pushed
the
pb/keys-dev-only
branch
from
aee0845
to
20b96e5
Compare
paulbrauner-da
requested review from
hrischuk-da,
a team,
filmackay,
garyverhaegen-da,
remyhaemmerle-da,
basvangijzel-DA,
akrmn,
dylant-da and
samuel-williams-da
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #18457
In LF 2.1, reject dars that define keys or use by-key operations upon decoding. Fix all the tests whose failure ensues by either:
The PR looks like there are many new lines, but that's because of the splitting of integration tests: the code is merely being moved around.
There's one part I'm not sure about: docs. I've documented that docs should drop keys in the TODO comment. I'm not sure if it's ok to add a TODO of if we try to keep the doc up-to-date as we modify the code.