Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPP-1327] Improve performance of transaction streaming by replacing the backend implementation #15770

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

pbatko-da
Copy link
Contributor

@pbatko-da pbatko-da commented Dec 2, 2022

Depends on #15703 - this PR shall be retargeted to main after the dependent PR is merged

@pbatko-da pbatko-da self-assigned this Dec 2, 2022
@pbatko-da pbatko-da changed the base branch from main to pbatko/etq-tx-streams December 2, 2022 16:57
@pbatko-da pbatko-da changed the base branch from pbatko/etq-tx-streams to main December 2, 2022 16:57
@pbatko-da pbatko-da changed the base branch from main to pbatko/etq-tx-streams December 2, 2022 16:57
@pbatko-da pbatko-da force-pushed the pbatko/etq-transactions-123 branch 2 times, most recently from 669a6f4 to 12fbdff Compare December 2, 2022 17:04
@pbatko-da pbatko-da force-pushed the pbatko/etq-transactions-123 branch 2 times, most recently from 9c2fef5 to b9ffc4f Compare December 2, 2022 18:36
@pbatko-da pbatko-da changed the title [DPP-1327] ETQ - wiring to streaming and pointwise tx reading [DPP-1327] ETQ - wiring to streaming and pointwise tx reading - WIP Dec 2, 2022
@pbatko-da pbatko-da changed the title [DPP-1327] ETQ - wiring to streaming and pointwise tx reading - WIP [DPP+1327] ETQ - wiring to streaming and pointwise tx reading - WIP Dec 2, 2022
@pbatko-da pbatko-da force-pushed the pbatko/etq-transactions-123 branch 2 times, most recently from ed3bb5f to 362cd69 Compare December 5, 2022 16:53
@pbatko-da pbatko-da changed the title [DPP+1327] ETQ - wiring to streaming and pointwise tx reading - WIP [DPP-1327] Improve performance of transaction streaming by replacing the backend implementation Dec 5, 2022
@pbatko-da pbatko-da marked this pull request as ready for review December 5, 2022 16:55
@pbatko-da pbatko-da requested a review from a team as a code owner December 5, 2022 16:55
Base automatically changed from pbatko/etq-tx-streams to main December 8, 2022 13:56
…the backend implementation

Includes both flat and tree transactions streaming.
Transactions streams are now build from quering new event id filter tables to obtain event ids and then querying event payload tables by those ids.
@pbatko-da pbatko-da merged commit 263b579 into main Dec 12, 2022
@pbatko-da pbatko-da deleted the pbatko/etq-transactions-123 branch December 12, 2022 15:35
pbatko-da added a commit that referenced this pull request Jan 5, 2023
These metrics where changed in a previous PR: #15770
This PR adjusts the metrics names and documents the changes.

Each of the metrics below is a family of metrics starting with such prefix.

New metrics:
daml_index_db_flat_transactions_stream_translation
daml_index_db_flat_transactions_stream_fetch_event_consuming_ids_stakeholder
daml_index_db_flat_transactions_stream_fetch_event_consuming_payloads
daml_index_db_flat_transactions_stream_fetch_event_create_ids_stakeholder
daml_index_db_flat_transactions_stream_fetch_event_create_payloads

daml_index_db_tree_transactions_stream_translation
daml_index_db_tree_transactions_stream_fetch_event_consuming_ids_non_stakeholder
daml_index_db_tree_transactions_stream_fetch_event_consuming_ids_stakeholder
daml_index_db_tree_transactions_stream_fetch_event_consuming_payloads
daml_index_db_tree_transactions_stream_fetch_event_create_ids_non_stakeholder
daml_index_db_tree_transactions_stream_fetch_event_create_ids_stakeholder
daml_index_db_tree_transactions_stream_fetch_event_create_payloads
daml_index_db_tree_transactions_stream_fetch_event_non_consuming_ids_informee
daml_index_db_tree_transactions_stream_fetch_event_non_consuming_payloads

Removed:
daml_index_db_get_flat_transactions
daml_index_db_get_transaction_trees
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants