Backport #10883 and #10918 #10924
Merged
Backport #10883 and #10918 #10924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires #10928 |
andreaslochbihler-da
added
the
needs-backport
5 tasks
* Reorder the observers for StreamConsumer to first filter and then take just one element, not the other way around CHANGELOG_BEGIN CHANGELOG_END * Refactor the test to get better stacktraces during failures * Remove unused import
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fabiotudone-da
approved these changes
Sep 20, 2021
ghost
approved these changes
Sep 20, 2021
| val duplicateResponses = | ||
| alreadyExistsResponses + internalResponses + abortedResponses | ||
| assert( | ||
| okResponses == 1 && duplicateResponses == numberOfParallelRequests - 1, |
There was a problem hiding this comment.
Suggested change
| okResponses == 1 && duplicateResponses == numberOfParallelRequests - 1, | |
| okResponses == 1 && duplicateResponses == expectedDuplicateResponses, |
| ledger: ParticipantTestContext, | ||
| party: Party, | ||
| request: T, | ||
| submitRequestAndGetStatus: T => Future[Code], |
There was a problem hiding this comment.
Suggested change
| submitRequestAndGetStatus: T => Future[Code], | |
| submitRequestAndGetStatusCode: T => Future[Code], |
| import com.daml.ledger.client.binding.Primitive.Party | ||
| import com.daml.ledger.test.model.Test.DummyWithAnnotation | ||
| import com.daml.ledger.test.model.Test.{Dummy, DummyWithAnnotation} | ||
| import io.grpc.Status | ||
| import io.grpc.Status.Code |
There was a problem hiding this comment.
I prefer not to import Code and instead use Status.Code. I find it clearer. Your call though.
| case GrpcException(status, _) => | ||
| Future.successful(status.getCode) | ||
| case NonFatal(otherException) => | ||
| fail(s"Not a GRPC exception $otherException", otherException) |
There was a problem hiding this comment.
Why include the exception twice?
Suggested change
| fail(s"Not a GRPC exception $otherException", otherException) | |
| fail(s"Not a GRPC exception.", otherException) |
|
None of my comments are mandatory for the backport. I just saw them now and I figured we can address these on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.