Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect unsynchronized contract table and retry #10617

Merged
merged 42 commits into from
Sep 28, 2021
Merged

detect unsynchronized contract table and retry #10617

merged 42 commits into from
Sep 28, 2021

Commits on Aug 18, 2021

  1. enumerating out-of-sync offsets at the DB level

    @S11001001
    S11001001 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    e5d02fe View commit details
    Browse the repository at this point in the history

  2. cleanup in lastOffset

    @S11001001
    S11001001 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    cd5d230 View commit details
    Browse the repository at this point in the history

  3. write the latest-requested-or-read offset when catching up 

    - Writing only the latest-read, as before, would imply unsynced offsets
  that are actually well-synced.  This puts the DB in a more uniform
  state, i.e. it should actually reflect the single value that the
  fetchAndPersist loop tries to catch everything up to.
    @S11001001
    S11001001 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    3bc02d4 View commit details
    Browse the repository at this point in the history

  4. detecting lagging offsets from the unsynced-offsets set 

    - Treating every unsynced offset as a lag would make us needlessly retry
  perfectly synchronized query results.
    @S11001001
    S11001001 committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    5f89e7b View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Merge commit 'f77cd0a81c4c77e082a8de2b6f5fdfd316f4a66f' into 10334-de… 

    …tect-contract-table-desync
    @S11001001
    S11001001 committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    71d1f38 View commit details
    Browse the repository at this point in the history

  2. add Foldable1 derived from Foldable for NonEmpty

    @S11001001
    S11001001 committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    b9725e7 View commit details
    Browse the repository at this point in the history

  3. nicer version of the unsynced function

    @S11001001
    S11001001 committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    3e41b15 View commit details
    Browse the repository at this point in the history

  4. ConnectionIO scalaz monad

    @S11001001
    S11001001 committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    6696b5d View commit details
    Browse the repository at this point in the history

  5. rename Offset.ordering to Offset ordering so it can be imported ver… 

    …batim
    @S11001001
    S11001001 committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    56b18be View commit details
    Browse the repository at this point in the history

  6. finish aggregating in the lag-detector function, compiles

    @S11001001
    S11001001 committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    e4cf94b View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Merge commit '2555dbb30bdaa96d516b2455125d8b4e8c1d6fd6' into 10334-de… 

    …tect-contract-table-desync
    @S11001001
    S11001001 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    fc79ee9 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Merge commit 'f576cdfd06cf33686385ad61df1583a8e0668d44' into 10334-de… 

    …tect-contract-table-desync
    @S11001001
    S11001001 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    34e2a2b View commit details
    Browse the repository at this point in the history

  2. port sjd

    @S11001001
    S11001001 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    4c94598 View commit details
    Browse the repository at this point in the history

  3. XTag, a scalaz 7.3-derived tag to allow stacked tags

    @S11001001
    S11001001 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    9ba9ebf View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. make the complicated aggregation properly testable

    @S11001001
    S11001001 committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    455e536 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. extra semantic corner cases I didn't think of

    @S11001001
    S11001001 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    582346e View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Merge commit 'ac02dbdeb925444579b1b8dd8738c3be9502283d' into 10334-de… 

    …tect-contract-table-desync
    @S11001001
    S11001001 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    a009b9b View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. tests for laggingOffsets

    @S11001001
    S11001001 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    ee75cc0 View commit details
    Browse the repository at this point in the history

  2. a way to rerun queries if the laggingOffsets check reveals inconsistency

    @S11001001
    S11001001 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    fd26984 View commit details
    Browse the repository at this point in the history

  3. if bookmark is ever different, we always have to rerun anyway

    @S11001001
    S11001001 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    f957c07 View commit details
    Browse the repository at this point in the history

  4. Merge commit 'ced4a272408cfc13b45da20da3607e2dd7e07389' into 10334-de… 

    …tect-contract-table-desync
    @S11001001
    S11001001 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    1482e6c View commit details
    Browse the repository at this point in the history

  5. boolean blindness

    @S11001001
    S11001001 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    a332798 View commit details
    Browse the repository at this point in the history

  6. incorporate laggingOffsets into fetchAndPersistBracket

    @S11001001
    S11001001 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    2839ac9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. split fetchAndPersist from getTermination and clean up its arguments

    @S11001001
    S11001001 committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    c00b2ba View commit details
    Browse the repository at this point in the history

  2. just compose functors

    @S11001001
    S11001001 committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    389a497 View commit details
    Browse the repository at this point in the history

  3. add looping to fetchAndPersistBracket

    @S11001001
    S11001001 committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    a9c6080 View commit details
    Browse the repository at this point in the history

  4. more mvo tests

    @S11001001
    S11001001 committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    95153be View commit details
    Browse the repository at this point in the history

  5. test unsyncedOffsets, too

    @S11001001
    S11001001 committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    f966692 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Lagginess collector

    @S11001001
    S11001001 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    361802f View commit details
    Browse the repository at this point in the history

  2. supply more likely actual data with mvo tests; don't trust Java equals

    @S11001001
    S11001001 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    de2a1d2 View commit details
    Browse the repository at this point in the history

  3. rework minimumViableOffsets to track sync states across template IDs

    @S11001001
    S11001001 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    5845a35 View commit details
    Browse the repository at this point in the history

  4. extra note

    @S11001001
    S11001001 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    4de5cb7 View commit details
    Browse the repository at this point in the history

  5. fix the tests to work against the stricter mvo

    @S11001001
    S11001001 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    4859b86 View commit details
    Browse the repository at this point in the history

  6. move surrogatesToDomains call

    @S11001001
    S11001001 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    72abc1b View commit details
    Browse the repository at this point in the history

  7. Merge commit '6bf45a344a07568f1c2564ba894860dd9b276129' into 10334-de… 

    …tect-contract-table-desync
    @S11001001
    S11001001 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    29f5964 View commit details
    Browse the repository at this point in the history

  8. more tests for lagginess accumulator

    @S11001001
    S11001001 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    5e4d279 View commit details
    Browse the repository at this point in the history

  9. add changelog 

    CHANGELOG_BEGIN
- [JSON API] Under rare conditions, a multi-template query backed by database
  could have an ACS portion that doesn't match its transaction stream, if
  updated concurrently.  This conditions is now checked and accounted for.
  See `issue #10617 <https://github.com/digital-asset/daml/pull/10617>`__.
CHANGELOG_END
    @S11001001
    S11001001 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    4020ce1 View commit details
    Browse the repository at this point in the history

  10. port toSeq to Scala 2.12

    @S11001001
    S11001001 committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    1d5f723 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. handle a corner case with offsets being too close to expected values

    @S11001001
    S11001001 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    6f11c86 View commit details
    Browse the repository at this point in the history

  2. Merge commit '9641fd5f83f5954add9fc147c9bd43e5a1abd885' into 10334-de… 

    …tect-contract-table-desync
    @S11001001
    S11001001 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    5da2571 View commit details
    Browse the repository at this point in the history

  3. didn't need XTag

    @S11001001
    S11001001 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    7930ff2 View commit details
    Browse the repository at this point in the history

  4. Merge commit '5458aa890ccb1da23b5e44f09d512d338074d5a6' into 10334-de… 

    …tect-contract-table-desync
    @S11001001
    S11001001 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    4a02764 View commit details
    Browse the repository at this point in the history