Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daml Interface Methods (PoC) #11006

Closed
7 of 9 tasks
sofiafaro-da opened this issue Sep 23, 2021 · 1 comment · Fixed by #11231
Closed
7 of 9 tasks

Daml Interface Methods (PoC) #11006

sofiafaro-da opened this issue Sep 23, 2021 · 1 comment · Fixed by #11231
Milestone
Daml Interfaces

Comments

@sofiafaro-da
Copy link
Contributor

sofiafaro-da commented Sep 23, 2021 •
edited
Loading

  • protobuf
  • haskell AST
  • haskell typechecker
  • lf conversion & ghc parser
  • scala AST
  • scala typechecker
  • speedy support
  • encoder TODOs
  • validation TODOs
@sofiafaro-da sofiafaro-da added this to the Daml Interfaces milestone Sep 23, 2021
@sofiafaro-da sofiafaro-da mentioned this issue Sep 23, 2021
Merged
6 tasks
sofiafaro-da added a commit that referenced this issue Sep 24, 2021
@sofiafaro-da
interface methods: Haskell AST for methods
81c8376 
Part of #11006. This leaves typechecker and LF conversion for later, on
the haskell side.

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Sep 24, 2021
Merged
6 tasks
sofiafaro-da added a commit that referenced this issue Sep 27, 2021
@sofiafaro-da
interface methods: Haskell AST (#11018)
4075624 
* interface methods: Haskell AST for methods

Part of #11006. This leaves typechecker and LF conversion for later, on
the haskell side.

changelog_begin
changelog_end

* Forgot ECallInterface in DecodeV1

* fix a test
sofiafaro-da added a commit that referenced this issue Sep 27, 2021
@sofiafaro-da
interface methods: Haskell Typechecker
e362c92 
part of #11006

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Sep 27, 2021
Merged
6 tasks
sofiafaro-da added a commit that referenced this issue Sep 27, 2021
@sofiafaro-da
interface methods: Haskell Typechecker (#11028)
0d3ae6e 
part of #11006

changelog_begin
changelog_end
sofiafaro-da added a commit that referenced this issue Sep 29, 2021
@sofiafaro-da
interface methods: Scala AST
4abd1df 
Part of #11006
This PR takes care of the Scala AST and decoder.
It leaves the encoder, type checker, and speedy for later.

changelog_begin
changelog_end
This was referenced Sep 29, 2021
Merged
Merged
sofiafaro-da added a commit that referenced this issue Sep 29, 2021
@sofiafaro-da
interface methods: Scala AST
737a7f2 
Part of #11006
This PR takes care of the Scala AST and decoder.
It leaves the encoder, type checker, and speedy for later.

changelog_begin
changelog_end
sofiafaro-da added a commit that referenced this issue Sep 29, 2021
@sofiafaro-da
interface methods: Speedy
b550c94 
Part of #11006

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Sep 29, 2021
Merged
6 tasks
mergify bot pushed a commit that referenced this issue Sep 29, 2021
@sofiafaro-da
interface methods: Scala AST (#11070)
c1d1521 
* interface methods: Scala AST

Part of #11006
This PR takes care of the Scala AST and decoder.
It leaves the encoder, type checker, and speedy for later.

changelog_begin
changelog_end

* scalafmt

* AstRewriter
mergify bot pushed a commit that referenced this issue Sep 30, 2021
@sofiafaro-da @remyhaemmerle-da
interface methods: Speedy (#11076)
bcd4686 
* interface methods: Scala AST

Part of #11006
This PR takes care of the Scala AST and decoder.
It leaves the encoder, type checker, and speedy for later.

changelog_begin
changelog_end

* scalafmt

* AstRewriter

* interface methods: Speedy

Part of #11006

changelog_begin
changelog_end

* scalafmt

* Remove InterfaceMethods test

* Update daml-lf/archive/src/main/scala/com/digitalasset/daml/lf/archive/DecodeV1.scala

Co-authored-by: Remy <remy.haemmerle@daml.com>

Co-authored-by: Remy <remy.haemmerle@daml.com>
sofiafaro-da added a commit that referenced this issue Sep 30, 2021
@sofiafaro-da
interface methods: Scala Typechecker
1469529 
Part of #11006.
I tried to match the behavior of the Haskell typechecker.

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Sep 30, 2021
Merged
6 tasks
mergify bot pushed a commit that referenced this issue Sep 30, 2021
@sofiafaro-da
interface methods: Scala Typechecker (#11097)
db75f7d 
* interface methods: Scala Typechecker

Part of #11006.
I tried to match the behavior of the Haskell typechecker.

changelog_begin
changelog_end

* scalafmt

* Fix type
@sofiafaro-da
Copy link
Contributor Author

Reopening since there are still some TODOs in the scala encoder and validation.

@sofiafaro-da sofiafaro-da reopened this Oct 11, 2021
@sofiafaro-da sofiafaro-da mentioned this issue Oct 13, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Daml Interfaces
Development

Successfully merging a pull request may close this issue.

interfaces: Do some TODOs digital-asset/daml
1 participant
@sofiafaro-da