Skip to content

Commit

Permalink
Remove HA indexer integration test on H2
Browse files Browse the repository at this point in the history
This test was supposed to always fail, but sometimes it passes

changelog_begin
changelog_end
  • Loading branch information
rautenrieth-da committed Sep 30, 2021
1 parent db75f7d commit acf5a5a
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import org.scalatest.time.{Millis, Seconds, Span}

import java.sql.Connection
import scala.concurrent.{ExecutionContext, Future}
import scala.util.Success

trait IndexerStabilitySpec
extends AsyncFlatSpec
Expand All @@ -29,8 +28,6 @@ trait IndexerStabilitySpec
// To be overriden by the spec implementation
def jdbcUrl: String

def haModeSupported: Boolean

// The default EC is coming from AsyncTestSuite and is serial, do not use it
implicit val ec: ExecutionContext = system.dispatcher
private implicit val loggingContext: LoggingContext = LoggingContext.ForTesting
Expand Down Expand Up @@ -104,15 +101,6 @@ trait IndexerStabilitySpec
Future.successful(())
}
.map(_ => succeed)
}.transform { result =>
if (haModeSupported) {
result
} else {
// If HA mode is not supported, the test must fail, but there are multiple reasons why it can fail.
// E.g., duplicate parameter table initialization, or duplicate event sequential ids.
assert(result.isFailure, "The test must fail if HA mode is not supported")
Success(succeed)
}
}

// Finds the first non-aborted indexer that has subscribed to the ReadService stream
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,4 @@ final class IndexerStabilityOracleSpec extends IndexerStabilitySpec with OracleA

override def jdbcUrl: String =
s"jdbc:oracle:thin:$oracleUser/$oraclePwd@localhost:$oraclePort/ORCLPDB1"
override def haModeSupported: Boolean = true
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,4 @@ import com.daml.testing.postgresql.PostgresAroundEach
final class IndexerStabilityPostgresSpec extends IndexerStabilitySpec with PostgresAroundEach {

override def jdbcUrl: String = postgresDatabase.url
override def haModeSupported: Boolean = true
}

0 comments on commit acf5a5a

Please sign in to comment.