Issue 236 improve standards in open api specs#252
Conversation
peterkvokacka-da
left a comment
peterkvokacka-da
left a comment
There was a problem hiding this comment.
Lots of errors (with different error statuses) on backend service impl were introduced in this PR, it would make sense then handle them properly in the frontend.
There is a different proposal #238 for NOT_FOUND error handling, while keeping our components loosely coupled.
quickstart/backend/src/main/java/com/digitalasset/quickstart/service/LicenseApiImpl.java
Outdated
Show resolved
Hide resolved
quickstart/backend/src/main/java/com/digitalasset/quickstart/service/ServiceUtils.java
Outdated
Show resolved
Hide resolved
quickstart/backend/src/main/java/com/digitalasset/quickstart/service/AppInstallsApiImpl.java
Outdated
Show resolved
Hide resolved
I thought about same idea, but after reading realise this proposal is base on Functional programming (which I agree on), but the Java style and its standards (we use the JdbcTemplate from springframework) is to follow try/catch system. I think we should stick to the idea that we are in Java world and get ourselves into the idea of manage Java style as users will be more use to Java style than FT style. |
You can catch them all in the proper layer DamlRepository or PQS and deal with them in your preferred way either FT style or not. Fronted should be adjusted anyway. |
quickstart/backend/src/main/java/com/digitalasset/quickstart/service/ServiceUtils.java
Outdated
Show resolved
Hide resolved
quickstart/backend/src/main/java/com/digitalasset/quickstart/service/AppInstallsApiImpl.java
Outdated
Show resolved
Hide resolved
quickstart/backend/src/main/java/com/digitalasset/quickstart/service/ServiceUtils.java
Outdated
Show resolved
Hide resolved
…or dao exceptions
quickstart/backend/src/main/java/com/digitalasset/quickstart/pqs/Pqs.java
Outdated
Show resolved
Hide resolved
erwin-ramirez-da
deleted the
issue-236-improve-standards-in-openAPI-specs
branch
* main: (33 commits) docs: capture-logs date or gdate (digital-asset#265) docs: canton console connections (digital-asset#272) docs: guidance for safari users (digital-asset#271) Add daml-test to CircleCI and split up configuration (digital-asset#268) fix canton OOM and reduce canton memory requirement from ~12 GB to ~3 GB fixed bootstrap loading (digital-asset#266) docs: resolve syntax comments re 167 (digital-asset#259) move away from auth.principal.attributes to auth.authorities to store partyId and tenantId (digital-asset#260) Issue 236 improve standards in open api specs (digital-asset#252) fix: code backtick (digital-asset#256) docs: Remove some extraneous tick marks. (digital-asset#255) docs: resize images (digital-asset#254) Bump vite from 6.3.5 to 6.3.6 in /quickstart/frontend (digital-asset#247) Bump axios from 1.9.0 to 1.12.1 in /quickstart/frontend (digital-asset#253) docs: fast path installation (digital-asset#250) curl_check: treat HTTP 201 and 204 as success (digital-asset#251) fix typo in topology diagram (digital-asset#249) dupdate explore demo w biz case better toc (digital-asset#248) DOCS: add vale prose linter and configuration (digital-asset#242) fixes bug to disallow duplicate tenantId and combination of clientId and issuerUrl (digital-asset#233) ... # Conflicts: # quickstart/compose.yaml # quickstart/daml/.gitignore # quickstart/docker/create-app-install-request/run.sh
2 participants
closes #236
closes #238
Updating definitions and implementations of the endpoints used in the user flow in the QS