Skip to content

Feature/table #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 19, 2022
Merged

Conversation

HybridFox
Copy link
Contributor

PR Checklist

This PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A changelog entry has been added to CHANGELOG.md if necessary

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • react application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Resolved issues

Copy link
Contributor

@jsebrech jsebrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

over het algemeen thumbs up. hier en daar nog enkele kleine nitpicks.

@HybridFox HybridFox requested a review from jsebrech January 14, 2022 12:12
Copy link
Contributor

@TriangleJuice TriangleJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zelfde (positieve) opmerking als Joeri: Great work! Ook nog wat nitpicks toegevoegd. Ook zeker erop letten dat je geen WCAG incompliant features toevoegt.

@TriangleJuice TriangleJuice merged commit 52311d3 into digipolisantwerp:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants