Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the Quality of Life/Developer Experience #578

Closed
wants to merge 6 commits into from
Closed

Improve the Quality of Life/Developer Experience #578

wants to merge 6 commits into from

Conversation

hoang-himself
Copy link
Contributor

@hoang-himself hoang-himself commented Aug 26, 2023 •
edited
Loading

  1. Make git handle line endings via gitattributes
  2. Move labels in Dockerfile higher (purely aesthetic)
  3. Set DEBIAN_FRONTEND=noninteractive in Dockerfile, this has no effect now but there's no telling the future
  4. Change trigger of SL CI because it requires write permissions to the repository, which is not enabled by default in forks, causing the workflow to fail all the time
  5. Use docker with subcommands for clarity
  6. Change trigger of Docker Image CI to only run on push to master

@hoang-himself hoang-himself marked this pull request as ready for review August 26, 2023 19:22
@hoang-himself hoang-himself deleted the qol branch August 27, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hoang-himself