wifi: rename discover access points and Wi-Fi receive timeout methods #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenmoral
requested changes
Dec 15, 2016
| /** | ||
| * Returns the Wi-Fi configured timeout for connecting, disconnecting and | ||
| * discovering access points. | ||
| * Returns the access point configured timeout for connecting, |
Member
There was a problem hiding this comment.
Better "configured access point timeout"?
| * Test method for {@link com.digi.xbee.api.WiFiDevice#setWiFiReceiveTimeout(int)}. | ||
| * Test method for {@link com.digi.xbee.api.WiFiDevice#setAccessPointTimeout(int)}. | ||
| * | ||
| * <p>Check that the Wi-Fi receive timeout cannot be set if it is negative throwing an |
Member
There was a problem hiding this comment.
s/Wi-Fi receive/access point
| * Test method for {@link com.digi.xbee.api.WiFiDevice#setAccessPointTimeout(int)} and | ||
| * {@link com.digi.xbee.api.WiFiDevice#getAccessPointTimeout()}. | ||
| * | ||
| * <p>Check that the Wi-Fi receive timeout can be set and get successfully.</p> |
Member
There was a problem hiding this comment.
s/Wi-Fi receive/access point
|
|
||
| // Constants. | ||
| private final static int DEFAULT_WIFI_RECEIVE_TIMETOUT = 15000; // 15 seconds of timeout to connect, disconnect and discover access points. | ||
| private final static int DEFAULT_ACCESS_POINT_TIMETOUT = 15000; // 15 seconds of timeout to connect, disconnect and discover access points. |
| @@ -192,11 +192,11 @@ public WiFiAssociationIndicationStatus getWiFiAssociationIndicationStatus() thro | |||
| * Discovers and reports the access point that matches the supplied SSID. | |||
Member
There was a problem hiding this comment.
Should we replace "discover" with "scan" in this method's doc?
- Renamed "discoverAccessPoints" method to "scanAccessPoints". - Renamed the "Wi-Fi receive timeout" to "access point timeout" and updated the methods names. - Updated references and tests. https://jira.digi.com/browse/XBJAPI-357 https://jira.digi.com/browse/XBJAPI-358 Signed-off-by: Diego Escalona <diego.escalona@digi.com>
diescalo
force-pushed
the
diescalo/XBJAPI-357
branch
from
7082619 to
44ed845
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the method names.
https://jira.digi.com/browse/XBJAPI-357
https://jira.digi.com/browse/XBJAPI-358
Signed-off-by: Diego Escalona diego.escalona@digi.com