Skip to content

Conversation

@rubenmoral
Copy link
Member

The examples are located in the 'communication/ip' category.

https://jira.digi.com/browse/XBJAPI-371

Signed-off-by: Ruben Moral Ruben.Moral@digi.com

@rubenmoral rubenmoral added this to the wifi milestone Dec 14, 2016
@rubenmoral rubenmoral self-assigned this Dec 14, 2016
@rubenmoral rubenmoral requested a review from diescalo December 14, 2016 15:17
@rubenmoral rubenmoral force-pushed the rmoral/ip_communication_samples branch from c7f2ff1 to 2edc203 Compare December 14, 2016 17:27
------------
To run this example you will need:

* At least two Internet capable XBee radios (for example Wi-Fi radios) in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is prepared for Wi-Fi modules, so I would change this line by

At least two XBee Wi-Fi radios

I have checked the ReadMe of the ConnectToEchoServerSample and I think we should change it there as well. In other examples we were using the XBeeDevice generic class and it didn't matter the kind of module we were connecting. But in these examples we are using final protocol classes such as WiFiDevice and CellularDevice. If the user connects a module of a different protocol than the class one the example will fail.

- 16-bit dest. port: The port number ('C0') of the receiver module,
26 16 by default.
- 16-bit source port: 00 00
- Protocol: What you prefer, TCP, UDP or TCP SSL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove TCP SSL from here, it is only available for Cellular and we have not tested it with the library,

From XXX.XXX.XXX.XXX >> 48 65 6C 6C 6F 20 58 42 65 65 21 | Hello XBee!

- Where XXX.XXX.XXX.XXX is the IP address of the remote XBee device that
sent the IPdata frame.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space between IP and data.

------------
To run this example you will need:

* At least two Internet capable XBee radios (for example Wi-Fi radios) in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is prepared for Wi-Fi modules, so I would change this line by

At least two XBee Wi-Fi radios

Running the example
-------------------
First, build the application. Then, you need to set up XCTU to see the data
received by the sender XBee device. Follow these steps to do so:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change 'received' by 'sent' here or rephrase it to "... to see the data received by the remote XBee device."

The examples are located in the 'communication/ip' category.

https://jira.digi.com/browse/XBJAPI-371

Signed-off-by: Ruben Moral <Ruben.Moral@digi.com>
@rubenmoral rubenmoral force-pushed the rmoral/ip_communication_samples branch from 2edc203 to 1cd0bfa Compare December 15, 2016 11:05
@rubenmoral rubenmoral merged commit 1cd0bfa into wlan_support Dec 15, 2016
@rubenmoral rubenmoral deleted the rmoral/ip_communication_samples branch December 15, 2016 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants