ip: use standard Inet4Address class for IPs instead of IP32BitAddress #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diescalo
requested changes
Dec 13, 2016
| * data and a flag indicating whether the data was | ||
| * sent via broadcast or not. | ||
| * data, the IP address that sent the data and a flag | ||
| * indicating whether the data was sent via broadcast |
Member
There was a problem hiding this comment.
I know that it is not part of this commit, but there is not a bradcast flag any longer. We should change the text to:
A {@code NetworkMessage} object containing the data, the IP address that sent the data, the source and destination ports and the {@code NetworkProtocol} of the transmission.
https://jira.digi.com/browse/XBJAPI-354 Signed-off-by: Ruben Moral <Ruben.Moral@digi.com>
rubenmoral
force-pushed
the
rmoral/inetaddresses
branch
from
2ecdea3 to
fcd1b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.digi.com/browse/XBJAPI-354
Signed-off-by: Ruben Moral Ruben.Moral@digi.com