wifi: add support to discover and connect to access points #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenmoral
requested changes
Dec 7, 2016
| * @see #setWiFiReceiveTimeout(int) | ||
| */ | ||
| public AccessPoint getAccessPoint(String ssid) throws XBeeException { | ||
| logger.debug("{}AS for '{}' access point.", toString(), ssid); |
Member
There was a problem hiding this comment.
Should we throw a NullPointerException if ssid == null?
| * @return The discovered access point with the given SSID, {@code null} | ||
| * if the timeout expires and the access point was not found. | ||
| * | ||
| * @throws InterfaceNotOpenException if the device is not open. |
Member
There was a problem hiding this comment.
For consistency with other methods, write if this device connection is not open..
| * {@code getWiFiReceiveTimeout} method.</p> | ||
| * | ||
| * <p>Once the module is connected to the access point, you can issue | ||
| * the {@code writeSettings} method to save the connection settings. This |
Member
There was a problem hiding this comment.
Maybe it's better to put {@link #writeChanges()} instead.
| * {@code getWiFiReceiveTimeout} method.</p> | ||
| * | ||
| * <p>Once the module is connected to the access point, you can issue | ||
| * the {@code writeSettings} method to save the connection settings. This |
Member
There was a problem hiding this comment.
Maybe it's better to put {@link #writeChanges()} instead.
| * @throws NullPointerException if {@code ssid == null}. | ||
| * @throws TimeoutException if there is a timeout sending the connect | ||
| * commands. | ||
| * @throws XBeeException if the access point with the provided SSID is |
Member
There was a problem hiding this comment.
Without seeing the code, I don't understand the first part of the sentence.
| * @throws NullPointerException if {@code ssid == null} or | ||
| * if {@code encryptionType == null}. | ||
| * | ||
| * @see com.digi.xbee.api.models.WiFiEncryptionType |
Member
There was a problem hiding this comment.
Add @see #AccessPoint(String, WiFiEncryptionType).
| * Returns the operating channel of the access point. | ||
| * | ||
| * @return The operating channel of the access point. | ||
| */ |
| * Sets the new channel of the access point. | ||
| * | ||
| * @param channel The new channel of the access point. | ||
| */ |
| * Returns the signal quality with the access point in %. | ||
| * | ||
| * @return The signal quality with the access point in %. | ||
| */ |
Member
There was a problem hiding this comment.
Add @see #setSignalQuality(int).
| * Sets the new signal quality with the access point. | ||
| * | ||
| * @param signalQuality The new signal quality with the access point. | ||
| */ |
Member
There was a problem hiding this comment.
Add @see #getSignalQuality().
- Added a new enumerator (WiFiAssociationIndicationStatus) to list the possible encryption types for the Wi-Fi access points. - Added the AccessPoint class that represents an access point. - Added new methods to discover access points, get a specific one, connect, disconnect and check connection status. - Added new methods to get and set the Wi-Fi receive timeout, used to connect, disconnect and discover access points. - Written the unit tests for the new code and updated some others. Signed-off-by: Diego Escalona <diego.escalona@digi.com>
diescalo
force-pushed
the
diescalo/wifi_access_points
branch
from
a0a3065 to
0f2b7db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possible encryption types for the Wi-Fi access points.
and disconnect.
connect, disconnect and discover access points.
Signed-off-by: Diego Escalona diego.escalona@digi.com