Wi-Fi frames #71
Merged
Wi-Fi frames #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rubenmoral
commented
Dec 2, 2016
rubenmoral
commented
- cellular: some improvements and changes in the cellular API frames
- wifi: add support for XBee Wi-Fi and Device Cloud API frames
diescalo
requested changes
Dec 2, 2016
| * @see #getRequestTarget() | ||
| */ | ||
| public void setRequestTarget(String target) { | ||
| if (target.length() > 255) |
Member
There was a problem hiding this comment.
Check first that target is not null.
| * @see com.digi.xbee.packet.XBeeAPIPacket#getAPIPacketParameters() | ||
| */ | ||
| @Override | ||
| public LinkedHashMap<String, String> getAPIPacketParameters() { |
Member
There was a problem hiding this comment.
For consistency, I think that we should format the parameters of the packets with the hexadecimal string followed by the interpreted value (when necessary).
| * using the parameters of the constructor or providing a valid API payload. | ||
| * | ||
| * <p>This frame type is sent out the serial port in response to the | ||
| * {@link SendDataRequestPacket}, providing its frame ID is non-zero.</p> |
Member
There was a problem hiding this comment.
providing its frame ID is non-zero... Should it be... providing its frame ID if it is non-zero ?
| * | ||
| * @return Received RF data. | ||
| * | ||
| * @see #setRFData(byte[]) |
Member
There was a problem hiding this comment.
There is not any setRFData(byte[]) method.
| parameters.put("Source address", sourceAddress.toString()); | ||
| parameters.put("RSSI", String.valueOf(rssi)); | ||
| parameters.put("Receive options", String.valueOf(receiveOptions)); | ||
| if (ioSample != null) |
Member
There was a problem hiding this comment.
I would add more detailed information about the sample here:
if (ioSample != null) {
parameters.put("Number of samples", HexUtils.prettyHexString(HexUtils.integerToHexString(1, 1))); // There is always 1 sample.
parameters.put("Digital channel mask", HexUtils.prettyHexString(HexUtils.integerToHexString(ioSample.getDigitalMask(), 2)));
parameters.put("Analog channel mask", HexUtils.prettyHexString(HexUtils.integerToHexString(ioSample.getAnalogMask(), 2)));
for (int i = 0; i < 16; i++) {
if (ioSample.hasDigitalValue(IOLine.getDIO(i)))
parameters.put(IOLine.getDIO(i).getName() + " digital value", ioSample.getDigitalValue(IOLine.getDIO(i)).getName());
}
for (int i = 0; i < 6; i++) {
if (ioSample.hasAnalogValue(IOLine.getDIO(i)))
parameters.put(IOLine.getDIO(i).getName() + " analog value", HexUtils.prettyHexString(HexUtils.integerToHexString(ioSample.getAnalogValue(IOLine.getDIO(i)), 2)));
}
} else if (rfData != null)
parameters.put("RF data", HexUtils.prettyHexString(HexUtils.byteArrayToHexString(rfData)));
| * | ||
| * @return The status of the device response. | ||
| * | ||
| * @see DeviceCloudStatus |
Member
There was a problem hiding this comment.
Add:
* @see #setStatus(DeviceCloudStatus)
| * | ||
| * @throws NullPointerException if {@code error == null}. | ||
| * | ||
| * @see FrameError |
| * | ||
| * @return The frame error. | ||
| * | ||
| * @see FrameError |
Member
There was a problem hiding this comment.
Add:
* @see setError(FrameError)
| * @throws NullPointerException if {@code status == null}. | ||
| * | ||
| * @see #getStatus() | ||
| * @see SendDataResponseStatus |
Member
There was a problem hiding this comment.
Replace by:
* @see DeviceCloudStatus
| * @return The file upload status. | ||
| * | ||
| * @see #setStatus(DeviceCloudStatus) | ||
| * @see SendDataResponseStatus |
Member
There was a problem hiding this comment.
Replace by:
* @see DeviceCloudStatus
Signed-off-by: Ruben Moral <Ruben.Moral@digi.com>
Wi-Fi frames: * 0x07 - Remote AT Command (Wi-Fi) * 0x87 - Remote AT Command Response (Wi-Fi) * 0x8F - IO Data Sample RX Indicator Device Cloud frames: * 0x28 - Send Data Request * 0x2A - Device Response * 0xB8 - Send Data Response * 0xB9 - Device Request * 0xBA - Device Response Status * 0xFE - Frame Error Unit tests for all new code https://jira.digi.com/browse/XBJAPI-316 Signed-off-by: Ruben Moral <Ruben.Moral@digi.com>
rubenmoral
force-pushed
the
rmoral/wifi_frames
branch
from
143734d to
4e4211f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.