Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/ver 123 #25

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Bug/ver 123 #25

merged 3 commits into from
Aug 23, 2023

Conversation

Ellenn-A
Copy link
Contributor

  • changed ipfs uploadFile and makeIpfsRequest so that uploadFile passes a FormData instead of Buffer
  • supportedIdentifier can now equal multiple formats - ifps, did:key, did:web
  • bumped version

@Ellenn-A Ellenn-A requested a review from n3op2 as a code owner August 23, 2023 15:06
mattdean-digicatapult
mattdean-digicatapult approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ellenn-A Ellenn-A merged commit ffbb2bb into main Aug 23, 2023
6 checks passed
@Ellenn-A Ellenn-A deleted the bug/VER-123 branch August 23, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdean-digicatapult mattdean-digicatapult mattdean-digicatapult approved these changes

@jonmattgray jonmattgray Awaiting requested review from jonmattgray

@n3op2 n3op2 Awaiting requested review from n3op2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ellenn-A @mattdean-digicatapult