Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #192

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

doowt
Copy link
Contributor

@doowt doowt commented Oct 9, 2024

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix
  • Chore
  • Feature
  • Documentation Update
  • Code style update (formatting, local variables)
  • Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets

N/a

High level description

This PR corrects the setup instructions for dealing with node-gyp errors.

xcode cannot be installed via brew as was described and xcode-select does not include the required utilities.

Detailed description

N/a

Describe alternatives you've considered

N/a

Operational impact

N/a

Additional context

N/a

This PR corrects the setup instructions for dealing with `node-gyp` errors.

`xcode` cannot be installed via brew as was described and `xcode-select` does not include the required utilities.
@doowt doowt requested a review from a team as a code owner October 9, 2024 09:13
@dblane-digicatapult dblane-digicatapult added the v:patch Change requires a semver patch version change label Oct 9, 2024
@dblane-digicatapult dblane-digicatapult merged commit b3f6a96 into main Oct 9, 2024
9 checks passed
@dblane-digicatapult dblane-digicatapult deleted the update-readme-setup-instructions branch October 9, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v:patch Change requires a semver patch version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants