Skip to content

Adding default factory to message type #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding default factory to message type #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c07999a
Adding default factory to message type
jacantwell Mar 26, 2025
8cbd78b
Updating test
jacantwell Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def test_message(message_data: dict):
assert message.model_dump() == message_data


@pytest.mark.parametrize("field", ["role", "content", "timestamp"])
@pytest.mark.parametrize("field", ["role", "content"])
def test_message_raise_missing(message_data: dict, field: str):
"""
Test that Message object raises an error when missing a required field.
Expand Down
4 changes: 2 additions & 2 deletions uncertainty_engine_types/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
from datetime import datetime
from typing import Any, Literal

from pydantic import BaseModel, field_validator
from pydantic import BaseModel, field_validator, Field


class Message(BaseModel):
role: Literal["instruction", "user", "engine"]
content: str
timestamp: datetime
timestamp: datetime = Field(default_factory=datetime.now)

@field_validator("content", mode="before")
@classmethod
Expand Down