Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Detail components have data to work with on "cursorStale" handlers #615

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Hiro-Nakamura
Copy link
Contributor

This is another fix for ns_app#550.

In this case, our ab.datacollection.updates were triggering a cursorStale with null as the parameter passed.

Our Detail Components were expecting proper values sent into the display data handler.

Release Notes

  • [fix] make sure Detail components have data to work with on "cursorStale" with null passed in.

Test Status

@Hiro-Nakamura Hiro-Nakamura added the patch Tag Pull Requests to trigger a patch version update label Jan 9, 2025
@Hiro-Nakamura Hiro-Nakamura requested a review from guyyoo January 9, 2025 00:09
Copy link
Contributor

@guyyoo guyyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiro-Nakamura Hiro-Nakamura merged commit 816a2b8 into master Jan 9, 2025
10 of 11 checks passed
@Hiro-Nakamura Hiro-Nakamura deleted the jh/NSAPP550 branch January 9, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Tag Pull Requests to trigger a patch version update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants