Fix/fail gracefully if teams fetch failed #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZIJ
approved these changes
Nov 22, 2023
vdmkenny
pushed a commit
to vdmkenny/digger
that referenced
this pull request
Feb 19, 2024
* report no changes if correctly * fail gracefully if teams fetching fails * fix syntax error * fix error in github teams Former-commit-id: d2eb083
ben-of-codecraft
pushed a commit
to ben-of-codecraft/digger
that referenced
this pull request
May 21, 2024
* report no changes if correctly * fail gracefully if teams fetching fails * fix syntax error * fix error in github teams Former-commit-id: d2eb083
breardon2011
pushed a commit
that referenced
this pull request
Sep 17, 2025
* report no changes if correctly * fail gracefully if teams fetching fails * fix syntax error * fix error in github teams Former-commit-id: d2eb083
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will be ignoring failing teams fetch for now since with token flow the only workaround is to place a bot token into the action. As a result the GH App driven flow is failing and only passes when you pass a bot token
This shouldn't be part of the onboarding for GH app, since the app does have access to fetch user teams
In the future the teams will be passed into the workflow from the backend to avoid this
For now we resort to a warning and passing an empty teams list into the policy if there is no access, while printing a warning.
In future changes we want to: