handle case when plan did not run due to locking gracefully #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZIJ
approved these changes
Feb 12, 2024
ben-of-codecraft
pushed a commit
to ben-of-codecraft/digger
that referenced
this pull request
May 21, 2024
breardon2011
pushed a commit
that referenced
this pull request
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1139
After introducing DiggerExecutorResult we missed a return at the end which occured when there is a locking error. A plan attempt of a locked project in digger is not considered as an error, so we don't return any errors, but we should return an empty ExecutorResult in order to avoid nilpointer exception in the accessor