-
Notifications
You must be signed in to change notification settings - Fork 45
fix: move types to separate package to prevent unnecessary CLI dependencies #4241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 24084a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: storybook - |
d1fa746 to
528f61c
Compare
528f61c to
dcc2de6
Compare
|
All in all, I think we should go ahead with this. |
Barsnes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll go ahead with this.
Having a type package will most likely be useful for a web components package as well.
I'm not sure if we need to publish this package locally before Github Actions, but we'll figure that out.
We might also need to check that sync-changelogs.js works, but I don't see why it should fail.
Summary
Move submodule
@digdir/designsystemet/typesto a new package@digdir/designsystemet-typesand change all references.After re-running
tokens builddownstream, this removes transitive dependencies on runtime dependencies on CLI tools likecommanderandstyle-dictionarywhich are never used in runtime, but are required for the CLI to function. It also makes code which doesn't use the CLI unaffected by our node version limitations (currently >= 22 due tostyle-dictionary).@digdir/designsystemet/typesis preserved for now as a deprecated re-export of@digdir/designsystemet-typesto avoid breaking people's builds.Checks
pnpm changesetif relevant)