fix(Popover): unnecesary call of onOpen and missing call of onClose

[unekinn]

Summary

Popover: Fix unnecesary call of onOpen and missing call of onClose

• Don't call onOpen when clicking Popover.Trigger when Popover is already open.
• Call onClose when a controlled Popover is closed by clicking on Popover.Trigger.

Checks

• I have read the contribution guidelines
• I have added a changeset (run pnpm changeset if relevant)

[changeset-bot]

🦋 Changeset detected

Latest commit: 4ab3095

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@digdir/designsystemet-react	Patch
@digdir/designsystemet	Patch
@digdir/designsystemet-css	Patch
@digdir/designsystemet-theme	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Preview deployments for this pull request:

storybook - 21. Nov 2025 - 14:18

[Barsnes]

Nitpick, but to make it more readable, could we swap the ifs, so we can do if (controlledOpen)?

[unekinn]

Were you thinking something like this? Not sure if it's actually more readable, but at least we only have the close logic once in this version.

        if (controlledOpen) {
          if (isTrigger) {
            event.preventDefault(); // Prevent native Popover API
          }
          if (isTrigger || isOutside) {
            setInternalOpen(false);
            onClose?.();
          }
        } else if (isTrigger) {
          event.preventDefault(); // Prevent native Popover API
          setInternalOpen(true);
          onOpen?.();
        }

[unekinn]

Or maybe like this

        if (isTrigger) {
          event.preventDefault(); // Prevent native Popover API
        }
        if (controlledOpen && (isTrigger || isOutside)) {
          setInternalOpen(false);
          onClose?.();
        } else if (isTrigger) {
          setInternalOpen(true);
          onOpen?.();
        }
      };

[Barsnes]

Liked your last suggestion, went ahead and added it to the PR

[Barsnes]

I'll make sure to fix this before next release 😄