Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): change moduleResolution to catch missing file extensions which cause trouble downstream #2909

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(cli): change moduleResolution to catch missing file extensions which cause trouble downstream #2909

merged 1 commit into from
Dec 16, 2024

Conversation

unekinn
Copy link
Contributor

@unekinn unekinn commented Dec 16, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 67eadc7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet Patch
@digdir/designsystemet-css Patch
@digdir/designsystemet-theme Patch
@digdir/designsystemet-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Preview deployments for this pull request:

Storybook - 16. Dec 2024 - 17:32

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 55.14% 3188 / 5781
🔵 Statements 55.14% 3188 / 5781
🔵 Functions 86.6% 181 / 209
🔵 Branches 77.19% 518 / 671
File CoverageNo changed files found.
Generated in workflow #1311 for commit 67eadc7 by the Vitest Coverage Report Action

@unekinn unekinn force-pushed the fix/cli-utils-import-error branch from a3f6490 to 67eadc7 Compare December 16, 2024 16:29
@unekinn
Copy link
Contributor Author

unekinn commented Dec 16, 2024

Tested and working:

  • yarn test in packages/cli
  • yarn theme (running theme builder locally)
  • yarn start:storefront (running storefront locally)
  • yarn build:all
  • CLI usage downstream no longer crashes, tested with pnpm link from Udir's monorepo

@mimarz mimarz merged commit 9b6401b into next Dec 16, 2024
10 checks passed
@mimarz mimarz deleted the fix/cli-utils-import-error branch December 16, 2024 19:51
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@Barsnes Barsnes Awaiting requested review from Barsnes Barsnes is a code owner

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unekinn @mimarz