Konstantin/fix/silence detection #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `removeSilences` method to `MediaClip` class for removing silence segments based on specified options. - Introduced `SilenceDetectionOptions` type for improved configuration of silence detection parameters. - Updated `AudioSource` class to utilize new silence detection logic, replacing the previous implementation. - Refactored silence detection utility to process audio buffers more efficiently. - Added `audio.fixtures.ts` for defining minimum sample rate constant. - Removed outdated silence detection tests from `audio.spec.ts` to streamline testing focus. These changes improve the performance and flexibility of silence handling in audio processing.
- Simplified the `removeSilences` method in `MediaClip` by removing unnecessary options, defaulting to a standard behavior. - Updated the `removeSilences` method signature in `MediaTrack` to use the new `SilenceRemoveOptions` type for consistency. - Added export for `media.types` to enhance type management in the media module. - Removed outdated mock tests related to silence removal to streamline the test suite. These changes enhance the clarity and maintainability of the silence removal logic in the audio processing workflow.
- Bump package version from 1.5.0 to 1.5.1 in package.json. - Ensure `removeSilences` method in `MediaClip` initializes correctly based on state. - Clarify documentation for `SilenceDetectionOptions`, specifying minimum duration in milliseconds. - Update silence detection utility to convert minimum duration from milliseconds to samples for accurate processing. These changes improve the robustness and clarity of silence handling in audio processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.